DragonFly BSD
DragonFly submit List (threaded) for 2004-09
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: timed contains buffer overflows, and more


From: "Douwe Kiela" <virtus@xxxxxxxxxx>
Date: Fri, 3 Sep 2004 20:50:03 +0200

"Matthew Dillon" <dillon@xxxxxxxxxxxxxxxxxxxx> wrote:
>     So, for example, I think it would be ok to mix (void) removal with,
>     say, declaration/assignment separation, but it would not be ok to mix
>     either of those with functional changes like strcpy->strlcpy.  You
could
>     mix strcpy->strlcpy and sprintf->snprintf changes together into one
>     patch but you should not mix that with, unrelated cleanups.
>
>     As it is I am going to have to separate out the timed work into two
>     separate commits.  I would prefer not to have to do that again because
>     it is going to take two hours of my time to fix just timed and it
doesn't
>     really help the project out if the patches you submit require a
committer
>     to spend as long or longer reviewing and/or separating them.
Alright.. I will do this.. and submit the patches to bugzilla. :-)




[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]