Re: atop defined

[Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>]

:I see
:#define atop(x)                 ((x) >> PAGE_SHIFT)
:in sys/*/include/param.h. And ptoa defined there too.
:
:I was building a package from pkgsrc that defined its own "atop" and 
:"ptoa. I finally used gcc -E to track down the various syntax errors and 
:found the "(x) >> PAGE_SHIFT".
:
:Should or could this definition be within the #ifdef _KERNEL ??
:
:For now, I just patch the third-party software.
:
:(Please CC me on replies.)
:
: Jeremy C. Reed

    It probably should be protected by:

    #if defined(_KERNEL) || defined(_KERNEL_STRUCTURES)

    Go ahead and test the change, committing it if buildworld and
    buildkernel still run to completion.

					-Matt
					Matthew Dillon 
					<dillon@xxxxxxxxxxxxx>