Re: cvs commit: src/sys/i386/i386 nexus.c src/sys/i386/include atomic.h src/sys/kern kern_poll.c lwkt_serialize.c src/sys/net if.c if_var.h rtsock.c src/sbin/ifconfig ifconfig.c src/sys/dev/netif/dc if_dc.c src/sys/dev/netif/em if_em.c if_em.h ...

[Hiten Pandya <hmp@xxxxxxxxxxxxx>]

24.GA1669@xxxxxxxxxxxxxxxxx> <200505290022.j4T0Mtr7027761@xxxxxxxxxxxxxxxxxxxx>
In-Reply-To: <200505290022.j4T0Mtr7027761@xxxxxxxxxxxxxxxxxxxx>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Lines: 35
NNTP-Posting-Host: 82.18.88.18
X-Trace: 1117333595 crater_reader.dragonflybsd.org 728 82.18.88.18
Xref: crater_reader.dragonflybsd.org dragonfly.commits:8894

I have got half a bottle of whiskey (Grants) down me, but lets make this
clear.  The if_capabilities should only tell what the interface CAN and
will support; nothing else.

The 'if_flags' field should note as to whether which of the capabilities
have been turned on.  Lets just keep it simple and non-argumentative guys.

Kind regards,

					Hiten Pandya


Matthew Dillon wrote:
>     I am getting tired of this argument.  You aren't even listening
>     to what I am saying.  I've said the same thing three times and
>     it's been completely ignored.
> 
>     Note something:  WE ARE NOT FREEBSD!  Just because FreeBSD does it 
>     wrong doesn't mean we should follow in their footsteps and do it wrong
>     too!
> 
>     VLAN support?  Your ifconfig should *FAIL* if the interface can't 
>     support it in its current state.  You still only need two flags, one
>     in if_flags and one in if_capabilities.  You certainly do *NOT* need
>     three flags!
> 
>     Same with hardware checksum support.  We only need two flags, one 
>     indicating that its possible, one indicating that it has been turned
>     on.    We don't need a flag saying it MIGHT be possible, another saying
>     that it IS posible in the current configuration, and a third saying 
>     that it's actually turned on.
> 
>     Simple, straightforward.  NOT trinary. 
> 
> 						-Matt