Re: cvs commit: src/sbin/route route.c

[Chris Pressey <cpressey@xxxxxxxxxxxxxxx>]

On Wed, 16 Mar 2005 05:56:34 +0100
Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx> wrote:

> On Tue, Mar 15, 2005 at 08:47:01PM -0800, Chris Pressey wrote:
> >   
> >   - start at sa_data, end at sa + sa_len (NOT sa_data + sa_len);
> >   - don't make assumptions about the size of u_short.
> 
> Actually this code this makes assumptions :)

Would uint16_t be preferable here?

> I think it should be:
> splim = (u_short *)sa +
>     (sa->sa_len - offsetof(sa->sa_data)) / sizeof(u_short);

I think that should be

  splim = (u_short *)sa->sa_data +
      (sa->sa_len - offsetof(sa->sa_data)) / sizeof(u_short);

but that'd be the same as the thing I committed, just longer.

> Beside, find a better way to do the hex printing, this is not
> endian neutral.

Would using htons be sufficient?

-Chris