DragonFly BSD
DragonFly commits List (threaded) for 2005-03
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sbin/route route.c


From: Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>
Date: Wed, 16 Mar 2005 05:56:34 +0100
Mail-followup-to: commits@crater.dragonflybsd.org

On Tue, Mar 15, 2005 at 08:47:01PM -0800, Chris Pressey wrote:
>   
>   - start at sa_data, end at sa + sa_len (NOT sa_data + sa_len);
>   - don't make assumptions about the size of u_short.

Actually this code this makes assumptions :)

I think it should be:
splim = (u_short *)sa +
    (sa->sa_len - offsetof(sa->sa_data)) / sizeof(u_short);

Beside, find a better way to do the hex printing, this is not
endian neutral.

Joerg



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]