DragonFly BSD
DragonFly submit List (threaded) for 2004-02
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: ACPI Fixes


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 19 Feb 2004 12:20:58 -0800 (PST)

:	Hmm, which makes me wonder.  How can lwkt_{get|rel}token()
:	accept an uninitialised token?  As far as I can tell, every
:	LWKT token needs to be initialised with lwkt_inittoken().
:
:	I tried grep'ing for lwkt_inittoken() in your patch, but I
:	did not get any results.
:
:		-Hiten
:		Hiten Pandya (hmp@xxxxxxxxxxxxx)

    It can't, now.  The old version of the token code stored a cpuid
    in the token, so a zero'd token was in fact a valid token.
    The new version stores a globaldata_t (pointer) in the token, so
    a zero'd token is *NOT* valid.

    This has revealed that quite a bit of code does not properly initialize
    the tokens they use.

					-Matt
					Matthew Dillon 
					<dillon@xxxxxxxxxxxxx>



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]