Re: pfs-update code does not check if 'snapshots' directory exists

[YONETANI Tomokazu <qhwt+dfly@xxxxxxxxxx>]

On Mon, Apr 26, 2010 at 02:32:56PM +0530, Siju George wrote:
> Is it a bug or was this done on purpose?

I'm not sure if it's intended, but if the specified directory doesn't exist,
the snapshots phase of `hammer cleanup' happily replaces the PFS symlink
with a snap-YYYYMMDD-hhmm and the subsequent phases fail.  Maybe cleanup
command should refuse to proceed if it doesn't have write access to the
snapshot directory (or print a warning and forget about it?).

Cheers.