DragonFly BSD
DragonFly submit List (threaded) for 2012-11
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

[DragonFlyBSD - Submit #2449] INVARIANTS option fix.


From: Adam Sakareassen via Redmine <bugtracker-admin@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 7 Nov 2012 21:21:41 -0800

Issue #2449 has been updated by Adam Sakareassen.

File 0001-Fix-INVARIANT-build-issue.patch added

> * I think the "++spin->countb;" can be moved up into the INVARIANTS too. 

I agree.  A new patch is attached with such changes. (Disregard the previous patch file)

countb is not referred to anywhere in the kernel code outside of Invariants code.  I have left it's definition in the header files at this stage.  It looks like some of the comments in those header files could use with an update.  It appears the code increments or decrements counta.  Rather than use a chase counter as the comments suggest.

>AFAIR, iwn(4) also has an INVARIANTS issue.

I'll have a look at a later stage.

----------------------------------------
Submit #2449: INVARIANTS option fix.
http://bugs.dragonflybsd.org/issues/2449

Author: Adam Sakareassen
Status: New
Priority: Normal
Assignee: 
Category: 
Target version: 


With the INVARIANTS option defined the kernel does not build.  
This small patch fixes the issue.


-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]