Re: asf patch

["Nicolas Thery" <nthery@xxxxxxxxx>]

2008/7/10 ejc <eric.j.christeson@gmail.com>:
> asf(8) dumps core if you give it '\n' as input.  More specifically, if
> it has less than 2 tokens.
> Patch attached.
> Thanks to Antonio Huete Jimenez for getting me interested in this.
>
> Index: usr.sbin/asf/asf.c
> ===================================================================
> RCS file: /home/dcvs2/src/usr.sbin/asf/asf.c,v
> retrieving revision 1.5
> diff -u -r1.5 asf.c
> --- usr.sbin/asf/asf.c  19 May 2008 10:13:08 -0000      1.5
> +++ usr.sbin/asf/asf.c  10 Jul 2008 21:26:11 -0000
> @@ -254,6 +254,8 @@
>            quad_t bssaddr;
>
>            tokens = tokenize(buf, token, MAXTOKEN);
> +           if (tokens <= 1)
> +               continue;
>            base = strtoll(token[2], NULL, 16);
>            if (!dofind) {
>                snprintf(ocbuf,
>

The patch looks fine.