DragonFly submit List (threaded) for 2008-01
DragonFly BSD
DragonFly submit List (threaded) for 2008-01
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: lockmgr_sleep() (was Re: ssleep() (was Re: mention msleep() in porting_drivers.txt))


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 16 Jan 2008 10:09:28 -0800 (PST)

    lockmgr_sleep(ident, lock, slpflags, wmesg, timeo)

    lockmgr_sleep can also figure out what kind of lock is held internally
    and deal with it, or it can just assume an exclusive lock.  Either way
    lkflags do not have to be passed to it.

:If we're going to rename msleep() to spin_sleep() anyway, I suggest changing
:the prototype to
:
:spin_sleep(void *ident, int flags, const char *wmesg, int timo,
:	struct spinlock *spin)

    We want all the *sleep() procedures to use a similar prototype,
    and in this case being compatible with our own history as well
    as FreeBSD's will reduce confusion to a minimum.  That means putting
    the lock as the second argument.

    spin_sleep(ident, spin, slpflags, wmesg, timeo)

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]