DragonFly submit List (threaded) for 2007-08
DragonFly BSD
DragonFly submit List (threaded) for 2007-08
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: fixes for src/sys/bus/firewire/firewire.c


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 24 Aug 2007 08:59:23 -0700 (PDT)

:taken from FreeBSD
:
:Index: firewire.c
:===================================================================
:RCS file: /usr/dfly/repo/src/sys/bus/firewire/firewire.c,v
:retrieving revision 1.18
:diff -u -r1.18 firewire.c
:--- firewire.c	22 Dec 2006 23:12:16 -0000	1.18
:+++ firewire.c	1 May 2007 15:09:51 -0000
:@@ -519,6 +519,7 @@
: 		STAILQ_REMOVE_HEAD(&xferq->q, link);
: 		xferq->queued --;
: 		xfer->resp = EAGAIN;
:+		xfer->state = FWXF_SENTERR;
: 		fw_xfer_done(xfer);

    Committed.

    The xfer allocs can't return NULL so I didn't commit the other bit.
    We could just remove all the NULL checks entirely, in fact.

						-Matt



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]