DragonFly BSD
DragonFly submit List (threaded) for 2006-06
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: Two trivial patches for /bin/sh


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Mon, 5 Jun 2006 08:56:03 -0700 (PDT)

:I wanted to submit these before I attempt any serious surgery on /bin/sh.
:
:These two patches *mostly* bring /bin/sh up to WARNS?=3D3. They don't corre=
:ct=20
:the "comparison is always true due to limited range of data type" errors th=
:at=20
:also appear on WARNS?=3D0.
:
:The eval.c patch fixes possible logjmp clobbering. The histedit.c patch fix=
:es=20
:a warning of possibly returning an uninitialized value from str_to_event. (=
:I=20
:initialize 'i' as well for good measure.)

    These patches didn't patch cleanly but since they are so trivial I
    was able to patch them in manually.

    I did something slightly different for histedit.c.  I only initiialized
    retval.  'i' doesn't need initialization at the top.

						-Matt



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]