Re: ipsec-tools patch

[joerg@xxxxxxxxxxxxxxxxx]

On Fri, Apr 28, 2006 at 02:16:30PM +0100, Gary Allan wrote:
> diff -ru ipsec-tools-0.6.5.orig/configure ipsec-tools-0.6.5/configure
> --- ipsec-tools-0.6.5.orig/configure	2006-04-28 09:36:25.000000000 +0100
> +++ ipsec-tools-0.6.5/configure	2006-04-28 13:48:34.000000000 +0100
> @@ -24212,7 +24212,14 @@
>  cat >>conftest.$ac_ext <<_ACEOF
>  /* end confdefs.h.  */
>  
> -		#include <openssl/sha.h>
> +#include <openssl/opensslv.h>
> +
> +/* OpenSSL 0.9.8 headers require size_t to be defined */
> +#if defined(OPENSSL_VERSION_NUMBER) && (OPENSSL_VERSION_NUMBER >= 0x0090800fL)
> +#include <sys/types.h>
> +#endif
> +
> +#include <openssl/sha.h>

Just include sys/types.h first. It is part of SUS and expected to exist
anywhere. Makes the code easier to read.

Rest looks fine, please submit upstream as well. BTW, kick them to fix
the yacc usage to always create the correct header file...

Joerg