DragonFly BSD
DragonFly submit List (threaded) for 2005-04
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: bin/mined cleanup stage1


From: "Liam J. Foy" <liamfoy@xxxxxxxxxxxxx>
Date: Tue, 26 Apr 2005 16:35:14 +0100

On Tue(26)/Apr/05 - , Joerg Sonnenberger wrote:
> On Tue, Apr 26, 2005 at 08:32:09PM +0800, Sepherosa Ziehau wrote:
> > 1) remove register keyword
> > 2) remove (void) before function call
> > 3) ANSIfy
> > 4) initialize stack variable properly
> > 5) WARNS 3
> > 
> > please review it
> 
> Can you redo the patch with the following changes please?
> 1) No prototype macros, real prototypes
> void	FS(void);
> 2) Line break after return type at declarations.
> 
> Thanks, Joerg

I see you called it Stage 1. When you're doing Stage 2, email
me. I will give you a list of other things which can be done.

-- 
Liam J. Foy
liamfoy@xxxxxxxxxxxxx
http://www.bsd-systems.co.uk



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]