DragonFly BSD
DragonFly submit List (threaded) for 2005-04
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: setenv return value cleanup


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 22 Apr 2005 09:32:41 -0700 (PDT)

:
:Hi,
:
:I have several more setenv return value cleanup patches, style(9)
:compliant. :-)  Should I submit these in batches or one at a time?
:
:Joe

    Sure.  In the case of 'resident' it's important to check the
    return value.  It may or may not be important in other cases.
    We don't want to add fluff to the code unless we have to!

    Shouldn't those warn()'s be err()'s ?  Not being able to 
    set the environment variable there should probably be fatal.

					-Matt
					Matthew Dillon 
					<dillon@xxxxxxxxxxxxx>



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]