DragonFly BSD
DragonFly submit List (threaded) for 2005-03
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: [PATCH]sbin/route WARNS=6 cleanup, Style(9), small bug fix


From: Chris Pressey <cpressey@xxxxxxxxxxxxxxx>
Date: Tue, 15 Mar 2005 20:31:24 -0800

On Tue, 8 Mar 2005 20:11:42 +0800 (CST)
Sepherosa Ziehau <sepherosa@xxxxxxxxxxxx> wrote:

> split original patch into small patches against each file in
> sbin/route add comments at the beginning of each file to indicate what
> it does patchbugfix.route.c is based on patch.route.c
> please view them.

OK, the WARNS cleanup is committed, thanks!

As for the bug, I'm not convinced your patch is the right fix - I'm not
even convinced there is a bug in the first place - but I am convinced
that that part of the code is EXTREMELY confusing, so I can't blame you
in the least :)  Thanks for pointing it out; I'll rewrite it into
something more manageable.

-Chris



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]