DragonFly BSD
DragonFly submit List (threaded) for 2005-03
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: ipw driver


From: Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>
Date: Tue, 8 Mar 2005 18:34:15 +0100
Mail-followup-to: submit@crater.dragonflybsd.org

On Tue, Mar 08, 2005 at 05:06:38PM +0000, Johannes Hofmann wrote:
> - use of DragonFly api instead of bpf_mtap2() and enable raw bpf related code.

That part is fine. Exception is the NBPFILTER > 0 check, that should just
go away.

> - use of IPW_LOCK/IPW_UNLOCK macros instead of directly using splimp()/splx().

This is fine.

> - make if_ipw.c WARNS?=6 clean.

I don't complete like the (void)arg2 and such in the sysctl handler,
but that can go away in the not the long future, if noone strongly
objects.

I'll commit it anyway.

Joerg



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]