DragonFly BSD
DragonFly submit List (threaded) for 2005-01
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: BPF extensions


From: Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>
Date: Tue, 25 Jan 2005 20:03:09 +0100
Mail-followup-to: submit@crater.dragonflybsd.org

On Mon, Jan 24, 2005 at 12:19:19PM -0800, Jeffrey Hsu wrote:
> +void
> +bpfattach2(struct ifnet *ifp, u_int dlt, u_int hdrlen, struct bpf_if 
> **driverp)
> 
> Same here.  Use a more descriptive name than attach2.

I've used bpfattach_dlt, that should perfectly reflect what the
function is about.

The patch (http://leaf.dragonflybsd.org/~joerg/bpf.diff) is updated
to reflect this change, the new comments for bpf_[m]_tap* and the
macros. The /* XXX */ comment has been replaced by the spl protection,
it's needed.

More comments?

Joerg



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]