Re: [PATCH] Dynamic kernel environment support (kgetenv() and friends), ACPI quirks

["Thomas E. Spanjaard" <tgen@xxxxxxxxxxxxx>]

Thomas E. Spanjaard wrote:
> Matthew Dillon wrote:
> >     * kenv_uninit() is holding a spin lock across a kfree(), which is
> >       not legal.  Of course, insofar as I can tell, kenv_uninit() will
> >       never run since it is a SYSUNINIT in a mandatry kernel module,
> >       so you could probably remove the whole routine and remove the
> >       SYSUNINIT :-).
> Yeah, I should just set kenv_isdynamic=0 right after locking, then 
> unlocking again, which would be sufficient.

Scratch that, there's always the possibility some other code is spinning 
on the lock while we set kenv_isdynamic to 0, e.g. in ksetenv() there's 
a large enough window. First set kenv_isdynamic to 0 (possibly with 
mplock held), spin on the lock to make sure all other threads are done 
with whatever they were doing while holding the lock, unlock, then free 
all stuff. But it doesn't matter ;).

Cheers,
--
        Thomas E. Spanjaard
        tgen@netphreax.net

Attachment: signature.asc
Description: OpenPGP digital signature