Re: [PATCH] Dynamic kernel environment support (kgetenv() and friends), ACPI quirks

[YONETANI Tomokazu <qhwt+dfly@xxxxxxxxxx>]

On Fri, Jan 12, 2007 at 07:00:13PM +0000, Thomas E. Spanjaard wrote:
> Attached patch adds dynamic kernel enviroment support, adapted from 
> FreeBSD; this allows us to actually be able to use ACPI quirks. As such 
> I also introduce an ACPI quirk entry for the VMware ACPI-fast24 timer, 
> which runs like mad.
> 
> If noone objects, I'll commit tomorrow.

As for dynamic kernel environment part, go ahead!  It also enables setting
debug.acpi.level and debug.acpi.layer with sysctl command, not just from
boot prompt.
As for quirk part, can you port acpi_quirk.c, acpi_quirks and
/sys/tools/acpi_quirks2h.awk from FreeBSD?  It seems it's already doing
what you say in the "XXX TGEN" comment.

Cheers.

> --- a/sys/dev/acpica5/acpi.c	Wed Jan 10 06:01:06 2007 +0000
> +++ b/sys/dev/acpica5/acpi.c	Sat Jan 20 05:52:40 2007 +0000
> @@ -31,6 +31,7 @@
>   */
>  
>  #include "opt_acpi.h"
> +
>  #include <sys/param.h>
>  #include <sys/kernel.h>
>  #include <sys/proc.h>

extra new line inserted, was this intended?

> diff -r c63dd4a6b22d sys/dev/acpica5/acpi_timer.c
> --- a/sys/dev/acpica5/acpi_timer.c	Wed Jan 10 06:01:06 2007 +0000
> +++ b/sys/dev/acpica5/acpi_timer.c	Fri Jan 12 13:21:16 2007 +0000
> @@ -27,7 +27,9 @@
>   * $FreeBSD: src/sys/dev/acpica/acpi_timer.c,v 1.33 2004/05/30 20:08:23 phk Exp $
>   * $DragonFly: src/sys/dev/acpica5/acpi_timer.c,v 1.11 2006/12/22 23:26:14 swildner Exp $
>   */
> +
>  #include "opt_acpi.h"
> +
>  #include <sys/param.h>
>  #include <sys/bus.h>
>  #include <sys/kernel.h>

extra new lines inserted(without any other changes), was this intended?

> diff -r c63dd4a6b22d sys/kern/kern_environment.c
> --- a/sys/kern/kern_environment.c	Wed Jan 10 06:01:06 2007 +0000
> +++ b/sys/kern/kern_environment.c	Mon Jan 22 08:03:13 2007 +0000
> @@ -29,23 +29,91 @@
[snip]

  :%!unexpand -t8

will replace leading whitespaces with tabs for you if you're using vi.

Cheers.