Re: URLs in commit messages

[Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>]

:-On [20050522 05:32], Sascha Wildner (saw@xxxxxxxxx) wrote:
:>* Do we really want this? :) I do because it's annoying to not being 
:>able to click on new files in order to see what's in them, but for 
:>larger numbers of new/removed files, this would add a bit of data to the 
:>messages.
:
:Somehow I doubt deleted is interesting.  New might be debateable.
:
:But the emails will in the end consist of more lines of URLs than log
:content.  I personally find it distracting, but hey.
:
:-- 
:Jeroen Ruigrok van der Werven <asmodai(at)wxs.nl> / asmodai / kita no mono
:Free Tibet! http://www.savetibet.org/ | http://ashemedai.deviantart.com/
:http://www.tendra.org/   | http://www.in-nomine.org/
:Trying to fool myself with Dreams that never come true...

    Yes, we really want it, even the ones that just generate '-' lines
    indicating deleted files.  The URL's are at the end of the commit mail
    for a reason :-)

    Even more interesting would be a *SINGLE* URL that generates the 
    entire patch set (including additions and deletions) all in one go.
    This way when someone makes a large commit I would only have to click
    on one URL to see the whole thing.

    Would you like to undertake that job?  I don't think it would be too
    difficult but for obvious reasons we can't just generate one big
    (multi-thousand-character-long) URL.  Browser's have limits to what
    they will allow.  What we want to do is to somehow reference the
    history file itself (e.g. /cvs/CVSROOT/history) by the transaction ID
    and then have a program get the file list from the history file.

    So, for example, one of Sascha's recent commits which includes some
    file removals is in the history file as follows:

M427cfd19|swildner|<remote>|src/etc|1.20|MAKEDEV
M427cfd19|swildner|<remote>|src/etc|1.56|Makefile
M427cfd19|swildner|<remote>|src/etc/mtree|1.33|BSD.usr.dist
M427cfd19|swildner|<remote>|src/share/man/man4|1.21|Makefile
M427cfd19|swildner|<remote>|src/share/man/man4|1.3|atkbd.4
R427cfd19|swildner|<remote>|src/share/man/man4|1.4|pcvt.4
M427cfd19|swildner|<remote>|src/share/man/man4|1.3|splash.4
M427cfd19|swildner|<remote>|src/share/man/man5|1.11|rc.conf.5
M427cfd19|swildner|<remote>|src/share/man/man7|1.5|hier.7
M427cfd19|swildner|<remote>|src/share/man/man8/man8.i386|1.5|MAKEDEV.8
M427cfd19|swildner|<remote>|src/share/mk|1.10|bsd.libnames.mk
M427cfd19|swildner|<remote>|src/share/termcap|1.3|termcap.src
M427cfd19|swildner|<remote>|src/sys/conf|1.6|files.amd64
M427cfd19|swildner|<remote>|src/sys/conf|1.30|files.i386
M427cfd19|swildner|<remote>|src/sys/conf|1.5|options.amd64
M427cfd19|swildner|<remote>|src/sys/conf|1.12|options.i386
M427cfd19|swildner|<remote>|src/sys/dev/misc/kbd|1.8|atkbd.c
R427cfd19|swildner|<remote>|src/sys/dev/video/pcvt/i386|1.3|pcvt_conf.h
R427cfd19|swildner|<remote>|src/sys/dev/video/pcvt/i386|1.13|pcvt_drv.c
R427cfd19|swildner|<remote>|src/sys/dev/video/pcvt/i386|1.7|pcvt_ext.c
R427cfd19|swildner|<remote>|src/sys/dev/video/pcvt/i386|1.7|pcvt_hdr.h
R427cfd19|swildner|<remote>|src/sys/dev/video/pcvt/i386|1.8|pcvt_kbd.c
R427cfd19|swildner|<remote>|src/sys/dev/video/pcvt/i386|1.3|pcvt_kbd.h
R427cfd19|swildner|<remote>|src/sys/dev/video/pcvt/i386|1.5|pcvt_out.c
R427cfd19|swildner|<remote>|src/sys/dev/video/pcvt/i386|1.6|pcvt_sup.c
R427cfd19|swildner|<remote>|src/sys/dev/video/pcvt/i386|1.3|pcvt_tbl.h
R427cfd19|swildner|<remote>|src/sys/dev/video/pcvt/i386|1.6|pcvt_vtf.c

    A URL that just references the history id, 427cfd19, should be
    sufficient for a program to be able to locate the enties in the
    history file and generate a diff.

					-Matt
					Matthew Dillon 
					<dillon@xxxxxxxxxxxxx>