DragonFly BSD
DragonFly kernel List (threaded) for 2004-09
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: callout patch - make callouts per-cpu and MP safe.

From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Tue, 14 Sep 2004 09:39:11 -0700 (PDT)

:On Mon, Sep 13, 2004 at 10:53:13PM -0700, Matthew Dillon wrote:
:>     This patch makes the kernel callout_*() interface per-cpu and MP safe.
:>     Individual callouts may also be registered as MP safe or not via a second
:>     argument to callout_reset() (using the same API a FreeBSD-5).
:I never liked the additional argument in FreeBSD-5, but I guess it can't be
:avoided for SMP safety. Does it imply that a MP-safe callout always runs on
:the CPU it was initially registered on? Have you looked at the timeout API
:from NetBSD/OpenBSD, they bind e.g. the function at init time. This might
:be more appropiate on this case.

    Well, except init time is usually in the startup code which is running
    on only one cpu.  I'm binding the cpu when the timeout is actually 
    started, in callout_reset().  We should probably have another API
    call to specify the cpu, e.g. callout_reset_oncpu(), for those
    subsystems which want to start their timeouts in the initialization

:I've been working on this already for dev/netif whenever I did greater changes
:to a driver. I've been working on other parts of the code base. If someone
:wants to submit patches, I'd like to coordinate this effort off-list.

    That would be helpful.

					Matthew Dillon 

[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]