DragonFly BSD
DragonFly commits List (threaded) for 2011-10
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: git: pmap - Missing critical section when calling lwkt_ipiq_process().


To: Antonio Huete Jimenez <tuxillo@xxxxxxxxxxxxxxxxxxxxxxx>
From: Alex Hornung <ahornung@xxxxxxxxx>
Date: Tue, 18 Oct 2011 06:24:59 +0100

Please MFC to 2.12.

Cheers,
Alex

On 17/10/11 23:09, Antonio Huete Jimenez wrote:
> commit 9d8625ebaab570eee3ac8eb7269d6001bcda19cf
> Author: Antonio Huete Jimenez <tuxillo@quantumachine.net>
> Date:   Mon Oct 17 12:26:22 2011 -0700
> 
>     pmap - Missing critical section when calling lwkt_ipiq_process().
>     
>     - pmap_interlock_wait() explicitly calls lwkt_process_ipiq() which expects to
>     be in a critical section. We still need cpu_ccfence() to guarantee that
>     pmap->pm_active is always read inside the loop.
>     
>     - Sync pmap_interlock_wait's comment for both i386 and x86_64.
>     
>     DragonFly-bug: <http://bugs.dragonflybsd.org/issue2152>
>     
>     Reviewed by: @dillon, @vsrinivas
> 
> Summary of changes:
>  sys/platform/pc32/i386/pmap.c   |    3 ++-
>  sys/platform/pc64/x86_64/pmap.c |   11 +++++++++--
>  2 files changed, 11 insertions(+), 3 deletions(-)
> 
> http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/9d8625ebaab570eee3ac8eb7269d6001bcda19cf
> 
> 




[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]