DragonFly BSD
DragonFly commits List (threaded) for 2011-04
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

git: kernel - Possible fix to 'Bad link elm' panic in random callout


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 5 Apr 2011 11:14:52 -0700 (PDT)

commit 8d4468507289f84cc7f60a6520c607713f84f009
Author: Matthew Dillon <dillon@apollo.backplane.com>
Date:   Tue Apr 5 11:08:34 2011 -0700

    kernel - Possible fix to 'Bad link elm' panic in random callout
    
    * Fix a rare race condition where the acquisition of p_token in the
      tsleep callout code can delay the setting of TDF_TIMEOUT, potentially
      causing it to skip the current tsleep entirely and trigger on a later
      tsleep.
    
      If this occurs the later callout is not terminated and tsleep() can return
      with it still active.  The callout is declared on the kernel stack, leading
      to the assertion and crash.
    
    * During evaluation I noticed that the corrupted callout structure in
      Rumko's crash dump contained information that indicated it was part of
      a stack frame.  I think only tsleep() declares callout structures on the
      stack.
    
    PR: 1977, 1835, 2037 (tracking using 2037)
    Reported-by: Rumko, Francois Tigeot <ftigeot@wolfpond.org>

Summary of changes:
 sys/kern/kern_event.c |    4 ++-
 sys/kern/kern_synch.c |   61 ++++++++++++++++++++++++++++++------------------
 2 files changed, 41 insertions(+), 24 deletions(-)

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/8d4468507289f84cc7f60a6520c607713f84f009


-- 
DragonFly BSD source repository



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]