DragonFly BSD
DragonFly commits List (threaded) for 2011-02
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

git: DragonFly_RELEASE_2_8 acpi(4): Always compile the files dealing with ACPI_DEBUG into the module.


From: Sascha Wildner <swildner@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 24 Feb 2011 02:12:06 -0800 (PST)

commit d03c03de0399753fa4b4fb7e5cb49486b87b1a81
Author: Sascha Wildner <saw@online.de>
Date:   Wed Feb 2 19:04:16 2011 +0100

    acpi(4): Always compile the files dealing with ACPI_DEBUG into the module.
    
    Before this commit, one had to define ACPI_DEBUG as a make variable to
    enable debugging support in the module, such as in:
    
    $ make -DACPI_DEBUG buildkernel
    
    Specifying ACPI_DEBUG in the kernel config alone did not enable it, but
    our modules are supposed to honor kernel options. Also this was contrary
    to what the manual page says.
    
    So to make this work for ACPI_DEBUG too, we just put all the affected
    source files into SRCS and always compile them. #ifdef's in these
    source files will take care of enabling/disabling debugging support
    so a module compiled without ACPI_DEBUG defined in the kernel or on the
    command line will still not have support after this commit (I've checked
    with nm(1)).
    
    The only change for someone not using ACPI_DEBUG is a little bit of
    additional buildkernel time.
    
    FWIW, it is the same way in FreeBSD, too.
    
    Reported-by: Andrea Magliano <masterblaster@tiscali.it>

Summary of changes:
 sys/dev/acpica5/Makefile |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/d03c03de0399753fa4b4fb7e5cb49486b87b1a81


-- 
DragonFly BSD source repository



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]