DragonFly BSD
DragonFly commits List (threaded) for 2010-01
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: git: kernel - Fix bug in recent swap/paging work


From: YONETANI Tomokazu <qhwt+dfly@xxxxxxxxxx>
Date: Sat, 23 Jan 2010 07:52:38 +0900

On 1/23/10 02:37 AM, Matthew Dillon wrote:
> commit 711a015923054632de5d5f62c613ad242cf82e29
> Author: Matthew Dillon<dillon@apollo.backplane.com>
> Date:   Fri Jan 22 09:35:24 2010 -0800
> 
>      kernel - Fix bug in recent swap/paging work
			:
> http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/711a015923054632de5d5f62c613ad242cf82e29

By the way, swap_pager_getpages() has the following code
starting from line 1207 (which is not affected by this
commit):
	for (i = 1; swap_burst_read &&
		    i < XIO_INTERNAL_PAGES &&
		    mreq->pindex + i < object->size; ++i) {
		daddr_t iblk;
		break;

The last `break' practically makes the loop no-op except
for changing the variable `i' when swap_burst_read is set.
Was this intended?

Cheers.



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]