DragonFly commits List (threaded) for 2009-08
DragonFly BSD
DragonFly commits List (threaded) for 2009-08
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

git: access(2): fix confusion between real and effective uid/gid


From: Nicolas Thery <nth@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 23 Aug 2009 00:01:42 -0700 (PDT)

commit 7ecca789d4f8366a6f54a1c889001f69b7ea3b1e
Author: Nicolas Thery <nthery@gmail.com>
Date:   Sat Aug 22 19:31:24 2009 +0200

    access(2): fix confusion between real and effective uid/gid
    
    Posix states that access() shall check permissions against
    real uid and gid but our implementation was using effective
    uid and gid instead.
    
    Change vop_helper_access accordingly.
    
    NOTE: This code will change soon when faccessat(2) is implemented
    but I'd rather not mix the bug fix with a new feature in a single
    commit.
    
    NOTE: nfs_access() may need to be fixed too but I haven't
    managed yet to figure out whether it should use real or
    effective uid.
    
    Fix-suggested-by: Alex Hornung <ahornung@gmail.com>
    Approved-by: dillon@

Summary of changes:
 sys/kern/vfs_helper.c |   21 +++++++++++++++++----
 1 files changed, 17 insertions(+), 4 deletions(-)

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/7ecca789d4f8366a6f54a1c889001f69b7ea3b1e


-- 
DragonFly BSD source repository



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]