DragonFly commits List (threaded) for 2008-01
DragonFly BSD
DragonFly commits List (threaded) for 2008-01
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sys/bus/firewire firewire.c fwdev.c fwdma.c fwmem.c fwohci.c src/sys/bus/pci pci.c src/sys/dev/disk/ata atapi-cd.c atapi-fd.c atapi-tape.c src/sys/dev/disk/isp isp_pci.c src/sys/dev/disk/mpt mpt_pci.c src/sys/dev/disk/nata ata-raid.c ...


From: Jason Smethers <jason@xxxxxxxxxxxx>
Date: Mon, 07 Jan 2008 02:37:30 -0600

Sascha Wildner wrote:
Remove bogus checks after kmalloc(M_WAITOK) which never returns NULL.


http://www.dragonflybsd.org/cvsweb/src/sys/dev/raid/twa/twa_cam.c.diff?r1=1.5&r2=1.6&f=u http://www.dragonflybsd.org/cvsweb/src/sys/dev/sound/pci/ds1.c.diff?r1=1.9&r2=1.10&f=u

You might want to revert these back to assigning the allocated memory to each's respective pointer, instead of always setting the pointer to NULL.



Jason




[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]