Re: cvs commit: src/share/man/man4 Makefile et.4 miibus.4 src/sys/dev/netif Makefile src/sys/dev/netif/et Makefile bitops.h if_et.c if_etreg.h if_etvar.h src/sys/dev/netif/mii_layer Makefile truephy.c truephyreg.h src/sys/conf files src/sys/config GE

["Sepherosa Ziehau" <sepherosa@xxxxxxxxx>]

On 10/14/07, Hasso Tepper <hasso@estpak.ee> wrote:
> Sepherosa Ziehau wrote:
> >   Added files:
> >     share/man/man4       et.4
> >     sys/dev/netif/et     Makefile bitops.h if_et.c if_etreg.h
> >                          if_etvar.h
> >     sys/dev/netif/mii_layer truephy.c truephyreg.h
>
> We already have one bitops.h in the tree. If two drivers are using them,
> I think that it's time to move these macros (although I personally don't
> like them) into some common header. cdefs.h?

There are actually three drivers using it (rtw(4) needs a little
twists, that why I didn't pull it up yet :).  I would put it under
sys/sys/ and keep it as bitops.h; merging it into cdefs.h will pollute
too many files.

Best Regards,
sephe

-- 
Live Free or Die