Re: cvs commit: src/share/man/man4 miibus.4 polling.4 vlan.4 src/sys/config LINT src/sys/boot/forth loader-bootp.conf loader.conf

[Christian Brueffer <chris@xxxxxxxxxxxxx>]

On Mon, May 28, 2007 at 06:50:44PM +0800, Sepherosa Ziehau wrote:
> On 5/28/07, Christian Brueffer <chris@unixpages.org> wrote:
> >Hi,
> >
> >have you actually tested bce(4) polling?  The polling code in the
> >FreeBSD driver is broken (made the mistake of adding bce(4) to
> >polling(4) as well ;-)
> 
> It works and I have tested it (test polling in dfly is much easier...)
> 
> I have adjusted following two things:
> 1) process POLL_AND_CHECK_STATUS in bce_poll(), which will affect link 
> status.
> 2) in bce_rx_intr(), we can't just process 'count' packets and leave,
> we need to process until there are no remaining packets in the current
> round, but don't update RX consumer index again in as we do in RX intr
> processing.
> 
> 1) was made before my first round polling testing, so I don't know
> whether it will have great impact on the bce(4).  But 2) does make
> things work.
> 

Nice to hear, thanks.  Do you plan to port these changes back to FreeBSD
yourself?

- Christian

-- 
Christian Brueffer	chris@unixpages.org	brueffer@FreeBSD.org
GPG Key:	 http://people.freebsd.org/~brueffer/brueffer.key.asc
GPG Fingerprint: A5C8 2099 19FF AACA F41B  B29B 6C76 178C A0ED 982D

Attachment: pgp00006.pgp
Description: PGP signature