Re: cvs commit: src/sys/dev/netif/wi if_wi.c

[Sepherosa Ziehau <sepherosa@xxxxxxxxx>]

if we have setup intr in the last step of  wi_attach(), then why not

in wi_detach():
. ..
bus_teardown_intr();
WL_UNLOCK();
wi_free();
. ..

in wi_free():
remove bus_teardown_intr() related code.  since with the above
changes, when wi_free() is called, intr is not setup (including setup
failure) or has been torn down

this way, we can leave crit-sect ASAP, also we meet the goal of this commit.

Best Regards,
sephe

On 7/4/05, Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> joerg       2005/07/03 09:47:20 PDT
> 
> DragonFly src repository
> 
>   Modified files:
>     sys/dev/netif/wi     if_wi.c
>   Log:
>   Slightly chance the order of interrupt handling. First hook the
>   interrupt up last and keep the critical section in detach.
>   This is a prequirement for the elimination of wi_gone.
> 
>   Revision  Changes    Path
>   1.29      +9 -12     src/sys/dev/netif/wi/if_wi.c
> 
> 
> http://www.dragonflybsd.org/cvsweb/src/sys/dev/netif/wi/if_wi.c.diff?r1=1.28&r2=1.29&f=u
> 


-- 
Live Free or Die