DragonFly BSD
DragonFly commits List (threaded) for 2005-06
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sys/sys ktr.h src/sys/conf options src/sys/kern kern_ktr.c src/sys/i386/conf LINT


From: Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>
Date: Tue, 21 Jun 2005 15:08:00 +0200
Mail-followup-to: commits@crater.dragonflybsd.org

On Mon, Jun 20, 2005 at 10:59:33AM -0700, Matthew Dillon wrote:
>   Reimplement the kernel tracepoint facility.  The new implementation is
>   completely generic and very easy to implement in modules.  Compile-time
>   optimizations are retained and sysctl generation is completely automatic.
>   Only the DDB command code has been retained from FreeBSD.

It is also not correct :( Now you can't log multiple arguments at all,
since putting the stack pointer into the KTR log means that we can't
correctly dump it later. The stack frame could have been overwritten
in the mean time, actually that's very likely.

That's why the original macros have been needed for. It can be safely
used only with one argument.

Joerg



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]