Re: cvs commit: src/share/mk bsd.port.mk

[Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>]

On Tue, May 17, 2005 at 08:59:20AM +0100, Stefan Krüger wrote:
> Joerg Sonnenberger wrote:
> > On Mon, May 16, 2005 at 07:40:02PM +0900, YONETANI Tomokazu wrote:
> > 
> >>That seems a bit harder (even assuming the iconv in libc is compatible
> >>with GNU libiconv), because all it does is adding dependency on
> >>converters/libiconv. The following patch overrides the USE_ICONV if
> >>USE_ICONV_IN_LIBC is also defined. Does it work for you?
> > 
> > 
> > It's not that easy, because some ports want to link against -liconv,
> > which would fail.
> yeah, like devel/glib20 IIRC, but we could get patches from NetBSD's
> pkgsrc and create a port override...

Most ports (like glib) have to necessary magic, but some have the -liconv
hardcoded in the Makefiles of the port. I have a local change in my pkgsrc
tree, still thinking about the best way to handle to OS version for
submitting it back.

Joerg