Re: cvs commit: src/sys/dev/netif/de if_de.c if_devar.h

[Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>]

On Thu, May 12, 2005 at 08:36:00AM +0800, Sepherosa Ziehau wrote:
> @@ -4184,16 +4172,14 @@ tulip_pci_attach(device_t dev)
> ......
> +	device_printf("address unknown\n");
> ......
> 
> Will it be `device_printf(dev, "address unknown\n");'?

Yeah.

> There are still quite a lot of netif driver using printf, I may help
> to change them into device_printf()/if_printf().

Please do so, send me the patches directly.

Rule of thumb is that device_printf is prefered for the initial part
before ether_ifattach and depending on the context for low-level
reports. The normal case should be if_printf (consistency with interface
renaming capability).

Joerg