Re: cvs commit: src/sys/boot/i386/boot2 boot2.c src/sys/boot/i386/libi386 comconsole.c src/sys/boot/i386/loader main.c

[YONETANI Tomokazu <qhwt+dfly@xxxxxxxxxx>]

On Wed, May 04, 2005 at 12:53:08PM -0700, Matthew Dillon wrote:
> :Why is the conditional "cmd[0] == 0" just before the second call
> :to parse() needed? It totally disables the boot.config feature,
> :and hitting Enter key ends up with a beep and won't let you use
> :the default configuration shown on the console.
> :...
> :
> :    for (;;) {
> :	printf("\nDragonFly boot\n"
> :	       "%u:%s(%u,%c)%s: ",
> :	       dsk.drive & DRV_MASK, dev_nm[dsk.type], dsk.unit,
> :	       'a' + dsk.part, kname);
> :	if (!autoboot || keyhit(5*SECOND))
> :	    getstr();
> :	else
> :	    putchar('\n');
> :	autoboot = 0;
> :	if (cmd[0] == 0 || parse())		/* <-- HERE */
> :	    putchar('\a');
> :	else
> :	    load();
> :    }
> :}
> 
>     Hmm.  I can't think of a reason.  Try removing it and see what
>     happens.  And I've noticed that issue too, it will be nice to
>     see it fixed.

I just installed the version without that conditional to my
laptop PC(of course I used `disklabel -B ad0s1':) before
posting the question. It worked as I expected. However I don't
have a serial cable right now, so if it's something to do with
serial-console, I can't test it.