cvs commit: src/sbin/mount mntopts.h src/sbin/newfs fscopy.c mkfs.c newfs.c

[Chris Pressey <cpressey@xxxxxxxxxxxxxxxxxxxxxxx>]

cpressey    2005/01/05 19:21:00 PST

DragonFly src repository

  Modified files:
    sbin/mount           mntopts.h 
    sbin/newfs           fscopy.c mkfs.c newfs.c 
  Log:
  Raise WARNS of newfs to 6:
  - Use static char buffer instead of string constant;
  - Move and add some function prototypes;
  - Don't reuse a scratch variable, use a real pid_t to hold the
    result of a fork();
  - Cast variables as needed (mainly to u_long and u_int32) to avoid
    signed-unsigned comparison warnings;
  - Rename some variables to avoid name clashes;
  - Mark some parameters as unused;
  - Add MOPT_NULL as a struct mntopt constant for terminating a list.
  
  And apply some style(9):
  - Move out some loop invariant code, for clarity;
  - Remove `register' keywords;
  - Make explicit some checks against NULL.
  
  Based-on-patch-by: Peter Schuller
                     <peter_dot_schuller_at_infidyne_dot_com>
  Tested-by: typical usage of installer
  
  Revision  Changes    Path
  1.4       +3 -0      src/sbin/mount/mntopts.h
  1.5       +5 -3      src/sbin/newfs/fscopy.c
  1.10      +59 -48    src/sbin/newfs/mkfs.c
  1.12      +10 -10    src/sbin/newfs/newfs.c


http://www.dragonflybsd.org/cvsweb/src/sbin/mount/mntopts.h.diff?r1=1.3&r2=1.4&f=u
http://www.dragonflybsd.org/cvsweb/src/sbin/newfs/fscopy.c.diff?r1=1.4&r2=1.5&f=u
http://www.dragonflybsd.org/cvsweb/src/sbin/newfs/mkfs.c.diff?r1=1.9&r2=1.10&f=u
http://www.dragonflybsd.org/cvsweb/src/sbin/newfs/newfs.c.diff?r1=1.11&r2=1.12&f=u