[DragonFlyBSD - Bug #2527] Re: git: build: implement automatic world backups

[John Marino via Redmine <bugtracker-admin@xxxxxxxxxxxxxxxxxxxxx>]

Issue #2527 has been updated by marino.


We will do something before release, don't worry about that.

I don't know what you mean by, there is no mechanism to change auto-backup dir, so we don't have a default.".  That is simply not true IMO.  The operator "?=" means define it as this *if* it's not already defined.  You can predefine auto-backup dir in make.conf.  So those that use NFS could define it anyway they think works.  We don't need to protect for lowest common denominator, it should be defaulted to the most common case.

Regardless if the current implementation isn't the best, you've introduced a regression.  In the end, we may accept that based on the full pros and cons but in general regressions should be avoided.  In the other hand, I haven't figured out how to make it better yet either.

The autobackup has basically been working in most cases, it's a couple of edge cases that's the problem (NFS + build as non-root).  The later can be "fixed" with your regression and the former is fixed with your patch.  Since that covers the known problems, I see no problem with the release.
----------------------------------------
Bug #2527: Re: git: build: implement automatic world backups
http://bugs.dragonflybsd.org/issues/2527

Author: c.turner1
Status: In Progress
Priority: Normal
Assignee: 
Category: 
Target version: 


On 02/17/13 14:43, John Marino wrote:

>      Additionally, every time the "installworld" target is executed, the same
>      directories will be automatically backed up at the location of
>      ${MAKEOBJDIRPREFIX}/world_backup .  These directories could be restored
>      with the new make target "restoreworld-auto".

Bug: This breaks on NFS object trees as the copy tries to set flags,
which can't be done over NFS

Also,

1) getting an 'off button' back for this would be swell
2) build(7) should probably be updated with whatever the final result is.

personally, I'd prefer this was optional behavior with an 'on' switch,
(e.g. it seems sort of like a 'developer setting' like CFLAGS, etc)

but, that's me.

sorry to back seat drive with no attched patch - lifes a bit hectic ATM.

Cheers,

- Chris


-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account