Re: atimes of binaries not properly updated

["Dionysus Blazakis" <dion.blazakis@xxxxxxxxx>]

On Wed, May 21, 2008 at 8:19 PM, Matthew Dillon
<dillon@apollo.backplane.com> wrote:
>
> :Hrm.  Nevermind.  The ucred's passed to the fs vnops are dereferenced
> :without check.
>
>     You can try passing FSCRED, which is basically a root cred from
>     process 0.
>
>                                        -Matt
>                                        Matthew Dillon
>                                        <dillon@backplane.com>
>

The issue is that FSCRED and NOCRED are checked in the kern_prot.c
helper functions, but the vnops functions in the various file systems
dereference the struct ucred pointers without checking for a
NULL(NOCRED) or 0xFFFFFFFF(FSCRED) pointers.  So what is the ideal
solution?  Should the ucred API be extended in kern_prot to do the uid
check that the file systems do (while taking into account NOCRED and
FSCRED)?

And I thought this was such a simple patch ;)

-- Dion