Re: [issue926] tcsh consumes much cpu when trying to gdb anything

["Nuno Antunes" <nuno.antunes@xxxxxxxxx>]

On Jan 24, 2008 12:25 PM, Simon 'corecode' Schubert
<corecode@fs.ei.tum.de> wrote:
> Nuno Antunes wrote:
> > Nuno Antunes <nuno.antunes@gmail.com> added the comment:
> >
> > Commenting out the SIGCHLD signal masking part seems to fix this issue for me.
> > But i'm not sure if this is a correct fix or not.
>
> Could you try the attached fix?
>
> cheers
>    simon
>
> --
> Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
> Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
> Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
> Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \
>
> Index: sys/signal2.h
> ===================================================================
> RCS file: /home/dcvs/src/sys/sys/signal2.h,v
> retrieving revision 1.1
> diff -u -p -r1.1 signal2.h
> --- sys/signal2.h       25 Feb 2007 23:17:13 -0000      1.1
> +++ sys/signal2.h       24 Jan 2008 09:27:00 -0000
> @@ -103,9 +103,8 @@ __cursignb(struct lwp *lp)
>         p = lp->lwp_proc;
>         tmpset = lwp_sigpend(lp);
>         SIGSETNAND(tmpset, lp->lwp_sigmask);
> -       if ((!(p->p_flag & P_TRACED) && SIGISEMPTY(tmpset))) {
> +       if (SIGISEMPTY(tmpset))
>                 return(FALSE);
> -       }
>         return (TRUE);
>  }
>
>
>

This fix from Simon seems to work for me. Are there any objections to
commiting this?

Thanks,
Nuno