Re: ATA identify retries exceeded - kernel panic

["Simon 'corecode' Schubert" <corecode@xxxxxxxxxxxx>]

Matthew Dillon wrote:
>     I agree that we should make M_ZERO semantics work more as expected...
>     or at least panic() if they aren't allowed.

yes, i agree.

>     Since bzero is a procedure call, perhaps the solution here is to add
>     another function pointer for 'zeroing' a structure when M_ZERO is
>     specified.  This function would be specified in objcache_create() and
>     default to a bzero if NULL.  This way M_ZERO will work as expected with
>     simple objcache setups, and panic the system if someone tries to use
>     it with more complex objcache setups (like mbufs).

I don't agree.  let's not make it more complex than it should be.  how about:  if there is no ctor you can specify M_ZERO.  if you specify a ctor, M_ZERO is a reason to panic.

cheers
 simon

--
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \

Attachment: signature.asc
Description: OpenPGP digital signature