DragonFly BSD
DragonFly bugs List (threaded) for 2006-07
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: brelse() panic


From: "Simon 'corecode' Schubert" <corecode@xxxxxxxxxxxx>
Date: Sun, 09 Jul 2006 23:04:46 +0200

Matthew Dillon wrote:
    I don't think checking 'error' here is going to matter.  In fact,
    I think the error assignment in the original code is probably wrong:

	vn_strategy(vp, &bp->b_bio1);
	error = bp->b_error;		<<<<<< HERE

    Most drivers set b_error when the I/O completes rather then from
    vn_strategy(), so error is most likely going to be 0 here.

I thought so as well, but: otherwise sascha's panic would never have occured, so error must have been set already.


cheers
 simon

--
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \

Attachment: signature.asc
Description: OpenPGP digital signature



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]