DragonFly BSD
DragonFly bugs List (threaded) for 2006-06
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: pppoe connection problems


From: YONETANI Tomokazu <qhwt+dfly@xxxxxxxxxx>
Date: Tue, 6 Jun 2006 20:26:06 +0900

On Mon, Jun 05, 2006 at 01:31:04PM -0700, Matthew Dillon wrote:
> :http://leaf.dragonflybsd.org/mailarchive/commits/2006-05/msg00113.html
> :netmsg embeded in the mbuf, hhhmmm... no idea
> :
> :unfortunately most of them are quite "big", touching many files etc; so
> :any help debugging this further appreciated
> 
>     It's probably this one, I'll take a look at it as soon as I get the
>     scheduler bug fixed.

Ok, here's a bandaid until Matt makes his mind on how to fix this issue
(other "do not reply!" comments may need similar bandaids depending
 on your network configuration):

Index: ng_base.c
===================================================================
RCS file: /home/source/dragonfly/cvs/src/sys/netgraph/netgraph/ng_base.c,v
retrieving revision 1.20
diff -u -r1.20 ng_base.c
--- ng_base.c	1 Jun 2006 06:10:54 -0000	1.20
+++ ng_base.c	6 Jun 2006 11:11:36 -0000
@@ -2087,7 +2087,9 @@
 		}
 	}
 out:
-	/* pmsg was embedded in the mbuf, do not reply! */
+	/* netgraph code may receive non embedded-in-mbuf netmsg's */
+	if (pmsg != &m->mh_netmsg.nm_lmsg)
+		lwkt_replymsg(pmsg->nm_lmsg, 0);
 	return(EASYNC);
 }
 



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]