Re: /dev permissions after reboot (and panic)

[Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>]

:Doing an ls after MAKEDEV shows correct permissions.  It's when I
:reboot when it comes back with a 644 mode.  So I think MAKEDEV
:is doing the right thing.

    I have not been able to dependably repeat the problem.  If
    you can, try this patch and tell me if the warning is
    spewed out on the console at any time.

					-Matt

Index: ufs_inode.c
===================================================================
RCS file: /cvs/src/sys/vfs/ufs/ufs_inode.c,v
retrieving revision 1.12
diff -u -r1.12 ufs_inode.c
--- ufs_inode.c	14 Dec 2004 23:59:47 -0000	1.12
+++ ufs_inode.c	17 Jul 2005 22:40:18 -0000
@@ -44,6 +44,7 @@
 #include "opt_ufs.h"
 
 #include <sys/param.h>
+#include <sys/systm.h>
 #include <sys/vnode.h>
 #include <sys/mount.h>
 #include <sys/malloc.h>
@@ -125,6 +126,11 @@
 		ip->i_flag |= IN_MODIFIED;
 		UFS_UPDATE(vp, 0);
 	}
+	if (ip && (ip->i_flag & (IN_ACCESS | IN_CHANGE | IN_MODIFIED | IN_UPDATE))) {
+		printf("WARNING: INODE %ld flags %08x: modified inode being released!\n", (long)ip->i_number, (int)ip->i_flag);
+		ip->i_flag |= IN_MODIFIED;
+		UFS_UPDATE(vp, 0);
+	}
 	/*
 	 * Remove the inode from its hash chain and purge namecache
 	 * data associated with the vnode.