Re: net/bpf.h issue

[Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>]

On Sat, Mar 19, 2005 at 12:22:13PM +0100, Joerg Anslik wrote:
> 
> Hi,
> 
> I think there's a flaw in our net/bpf.h when pcap.h is also included;
> I just came accross this when trying to compile "hping" from ports:
[snip]
> 
> Compiling a short test code like
> 
> #include <pcap.h>
> #include <net/bpf.h>
> main(){}
> 
> produces the same errors. I got rid of this by including a few
> "#ifndef ..." statements in net/bpf.h, but I didn't take a closer look
> at the overall stuff, so I'm not quite sure if this is the right
> place.

No, please don't. Either it should be a hard requirement that you can't
include both, or pcap-bpf.h should just die. I'm currently mostly in
favour of the latter, e.g. replacing it with an include to net/bpf.h.

Joerg