Re: Looks like split of execve(2) syscall created bugs

[Maxim Sobolev <sobomax@xxxxxxxxxxx>]

Full patch is here: http://www.portaone.com/~sobomax/diff

Apart from fixing above mentioned bugs it simplifies the code by 
removing not really necessary gotos.

-Maxim

Maxim Sobolev wrote:
> On Sat, Jan 29, 2005 at 02:42:32PM -0800, Matthew Dillon wrote:
>
> > :I can't agree. It's much easier to handle it in the
> > :imgact_shell - it only adds 2 new lines of the code.
> > :Additional benefit will be that the code is the same
> > :in FreeBSD and DF after that (you are probably don't
> > :care, but anyway ;), since it's what I am going to
> > :commit in few minutes.
> > :
> > :-Maxim
> > :
> > :Index: imgact_shell.c
> > :===================================================================
> > :RCS file: /home/dcvs/src/sys/kern/imgact_shell.c,v
> > :...
> >
> >   ewww.   I don't like the idea of doing something in one module and
> >   undoing it in another.  It's too much of a hack.  Lets try to come up
> >   with a better solution.
>
>
> Not quite. I've removed code which makes argv[0] == NULL
> a special case completely from kern_exec.c, but just haven't
> included relevant patch into this message since considered
> it obvious. If you want, I can probably make complete patch
> which will bring DF on par with FreeBSD, but I want to complete
> testing and commit my changes into FreeBSD repo first.
>
> -Maxim