nasty dev strategy related ata-raid bug

[Andrew Atrens <atrens@xxxxxxxxxxxxxxxxxx>]

This one is pretty nasty. In my case it caused ata-raid to mark my raid 
array broken, then write that config out to the array. On the subsequent
reboot the highpoint bios wouldn't boot because the raid had been marked 
damaged. The only way forward was to destroy and recreate the array 
using the same settings and rebuild the partition tables from scratch ( 
a task made less harrowing by scan_ffs ).

Sorry about the line wrapping, my email client is having a bad day ;)

Andrew.


#if 0
            /*
             *  Very Harmful
             */
            if ((rdp->disks[buf1->drive].flags &

(AR_DF_PRESENT|AR_DF_ONLINE))==(AR_DF_PRESENT|AR_DF_ONLINE) &&
                !AD_SOFTC(rdp->disks[buf1->drive])->dev->si_disk) {
                rdp->disks[buf1->drive].flags &= ~AR_DF_ONLINE;
                change = 1;
            }
            if ((rdp->disks[buf1->drive + rdp->width].flags &

(AR_DF_PRESENT|AR_DF_ONLINE))==(AR_DF_PRESENT|AR_DF_ONLINE) &&
                !AD_SOFTC(rdp->disks[buf1->drive + 
rdp->width])->dev->si_disk) {
                rdp->disks[buf1->drive + rdp->width].flags &= 
~AR_DF_ONLINE;
                change = 1;
            }
#endif