DragonFly submit List (threaded) for 2008-10
DragonFly BSD
DragonFly submit List (threaded) for 2008-10
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: fix ip_input m_len assertion


From: "Nicolas Thery" <nthery@xxxxxxxxx>
Date: Mon, 27 Oct 2008 18:35:34 +0100

2008/10/27 Sepherosa Ziehau <sepherosa@gmail.com>:
> Hi all,
>
> Following patch fixes:
> - The assertion in ip_input, should test sizeof(struct ip) instead of sizeof(ip)
> - Make sure that ip_input's precondition meets in ip_localforward
> - Don't allow raw ip socket to send ip packet whose header length is
> less than the minimum
>
> http://leaf.dragonflybsd.org/~sephe/ip_assert.diff
>
> Please test/review.

The diff looks fine to me  (but I don't know much about networking).

Out of curiosity in ip_localforward(), how can the packet be freed
while we are trying to forward it?

+				/* The packet was freed; we are done */

Cheers,
Nicolas



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]