DragonFly BSD
DragonFly submit List (threaded) for 2006-09
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: rc.d standardization patch


From: Victor Balada Diaz <victor@xxxxxxxxx>
Date: Fri, 29 Sep 2006 18:18:28 +0200

Hi,
I've found a little problem with your patch: if some user made script
does have something like checkyesno foo_enable it will fail. Will work
with foo_enable_enable="YES|NO" and foo_enable="YES|NO", but not
with foo="YES|NO". ie, the new expected behaviour.

I don't think that we should switch to foo="YES|NO", it will require
a lot of documentation changes and will break POLA.

I've created a patch[1] inspired by yours that allows to use
foo_enable="YES|NO" and foo="YES|NO" with pkgsrc and base apps.
It's much smaller, don't require documentation changes and gives
us the choice of working the way we want without imposing anything
to the user.

This is a bit hackish, because the place it should be fixed is on
pkgsrc, but i doubt this is doable as of now.

[1]: http://bsdes.net/~victor/dfbsd/rc.subr.patch
-- 
La prueba más fehaciente de que existe vida inteligente en otros
planetas, es que no han intentado contactar con nosotros. 



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]