DragonFly BSD
DragonFly submit List (threaded) for 2004-02
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cleaned up x11/nvidia-driver override port


From: Emiel Kollof <coolvibe@xxxxxxxxxxxxxxxx>
Date: Thu, 12 Feb 2004 01:31:34 +0100

Op Thursday 12 February 2004 01:10, schreef Matthew Dillon:
>     Emiel, after unpacking your new patch the only difference relative to
>     your initial submission that David committed on 1/14 is that you've
>     added a new file, "files/patch-dfly".
>
>     Is this correct?

I changed the patch name, it's more obvious that it's a dragonfly-specific 
patch that way. The ports system picks up the patch anyway. Maybe I'll split 
up the patches into which files they change some day if that's wanted :)

Also in the patch itself I added a new header file nv-dragonfly.h (which is 
just DragonFly specific), and split up dragonfly and freebsd cdevsw[] 
structures more, so it's easier to change if anything in dragonfly changes, 
instead of hopping around the #ifdef's all the time.

>     p.s. please don't use shar!  tar is fine, and for patch sets like these
>     it's even better to use a 'diff -r -u -N oldir newdir' or 'cvs diff' if
> you aren't adding any new files, or 'cvs diff -N' if the changes do include
> new files and you've cvs add'd the files to your local repository. 
> Finally, do not include the 'CVS' directories when posting a submission.

Will remember that next time. I thought shar was the preferred formats for 
ports? Oh well, I can just as easily make a tarball. 

I can easily resubmit if there are any further objections.

Cheers,
Emiel
-- 
The faster we go, the rounder we get.
		-- The Grateful Dead



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]