DragonFly BSD
DragonFly submit List (threaded) for 2003-12
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: (set|rem)runqueue and splhigh


From: Peter Kadau <peter.kadau@xxxxxxxxxxxxxxxx>
Date: Wed, 31 Dec 2003 20:40:05 +0100

Hi !

    The comment is not correct.  setrunqueue() already enters a critical
    section (see the crit_enter() and crit_exit() in setrunqueue()), which
    is equivalent to splhigh().  So the following is not needed.
Ahh, sorry for bothering you. Since the attachment was *very* small
I didn't ask first, which I would have done otherwise.

So, how about the brackets in vm/vm_glue.c and kern/kern_fork.c
in swapout/faultin and start_forked_proc respectively ?
Are they still needed to protect the flags or are they artefacts as well ?

Cheers
Peter

--
<peter.kadau@xxxxxxxxxxxxxxxx>

Campus der Max-Planck-Institute Tübingen
Netzwerk- und Systemadministration

Tel: +49 7071 601 598
Fax: +49 7071 601 616




[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]